Add pause-at-layer functionality for 3092 #4177

goofdad · 2017-10-31T20:56:25Z

Added 2 new configuration parameters: pause_gcode and pause_heights.

pause_gcode is under the Custom G-Code section of Printer Configuration.
pause_heights is under Layers and perimeters section of Print Configuration.

also added a test case.

lordofhyphens

I like that a test was added, but there are a few usability questions/issues.

Philosophical Questions

With custom conditional gcode, this is basically a shortcut to adding an (if [layer_num] == x) to before_layer_gcode (or after_layer_gcode) statements.

Does it come up enough to warrant yet another custom Gcode configuration option?

UI

While pausing at layer height X will probably be the most common use-case for this, it is more generically a before_layer_gcode that is only applied to specified Z heights. I think the configuration option name should suit this.

lordofhyphens · 2017-11-01T03:14:24Z

xs/src/libslic3r/PrintConfig.hpp

@@ -355,6 +357,8 @@ class GCodeConfig : public virtual StaticPrintConfig
    }

    virtual ConfigOption* optptr(const t_config_option_key &opt_key, bool create = false) {
+        OPT_PTR(pause_gcode);
+        OPT_PTR(pause_heights);


Please move these so that they're in alphabetical order in the list.

lordofhyphens · 2017-11-01T03:14:29Z

xs/src/libslic3r/PrintConfig.hpp

@@ -314,6 +314,8 @@ class PrintRegionConfig : public virtual StaticPrintConfig
 class GCodeConfig : public virtual StaticPrintConfig
 {
    public:
+    ConfigOptionString              pause_gcode;
+    ConfigOptionString              pause_heights;


Please move these so that they're in alphabetical order in the list.

lordofhyphens · 2017-11-01T03:20:07Z

lib/Slic3r/Print/GCode.pm

@@ -453,6 +453,16 @@ sub process_layer {
        $pp->set('layer_z'   => $layer->print_z);
        $gcode .= Slic3r::ConditionalGCode::apply_math($pp->process($self->print->config->layer_gcode) . "\n");
    }
+    if ($self->print->config->pause_gcode && $self->print->config->pause_heights) {
+        foreach my $height (split / /, $self->print->config->pause_heights) {
+            if ($height && $height eq $layer->print_z) {


Wouldn't it be appropriate to round the effective height (either up or down, down may be the safer option) if the current layer doesn't land on the prescribed height?

It's something that can occur often with adaptive slicing turned on or if there's some oddball floating point math going on internally.

Obviously you'd want to extend the tooltip appropriately.

I'll have to play with how this interacts with Adaptive Slicing, but my gut says no. I also work with ideamaker, which has this feature and does such rouding ... and the end result is that I have to manually open my gcode after export to make sure it paused where I wanted it to. They have multiple bugs open because of this. (now ... I have to open the gcode anyway because they don't allow me to customize the code inserted, but that's a different story).

Since logically this is intended to be a before-layer gcode, using floor() would seem to be safe (as opposed to round(), which could go up or down and definitely could confuse people).

That is, if layer 5 spans z=0.1 and z=0.3 and z=0.2 was requested, it would be inserted at 0.1. If z=0.299999999 was requested, it'd still be at z=0.1.

lordofhyphens · 2017-11-01T04:28:03Z

Implementing #4178 is another route to getting this PR with this functionality in ;)

goofdad · 2017-11-01T04:39:05Z

I'll look at some changes in the morning after coffee (never code before coffee!).
I'll also take a look at #4178 because I agree ... the UI is getting cluttered!

goofdad · 2017-11-01T04:41:56Z

In response to your Philosophical Question:
For me, the workflow warrants being separate and not an if statement. Philosophically, the actual code being inserted is printer specific, and thus belongs in the "Printer" config, while the layers needed is part of this specific print, and thus belongs in the "Print" config. I wouldn't want to need to go mucking about with my Printer config for each and every print where I wanted a pause.

lordofhyphens · 2017-11-01T04:47:07Z

@goofdad I did write #4178 with your use-case in mind ;)

I also just edited the main description to put some notes on some places that would need to be touched to implement this (not an exhaustive list).

I may have been thinking about collapsing Custom GCode into one UI element for months now (at least how it would work from the user's perspective).

ledvinap · 2017-11-01T08:28:16Z

One possibility is to replace pause_heights with mark_heights and allow G-code scripting to access mark status (possibly with set of mark values).
Then before_layer_gcode would just use {if [layer_mark]} (or {if [layer_mark] == 2} / {if [layer_mark] & 0x04})
Similar mechanism could be used for example in other g-code parts (toolchange gcode - pause before toolchange on specific layer)

goofdad · 2017-11-01T13:49:21Z

I actually like the layer mark idea, but I'd like it to be more general. Now I'm contemplating syntax between what belongs on the "Printer" side and what belongs on the "Print" side.

lordofhyphens · 2017-11-01T19:01:28Z

I am down with both (hence overrides in Print and Filament). On Nov 1, 2017 8:49 AM, "goofdad" <[email protected]> wrote: I actually like the layer mark idea, but I'd like it to be more general. Now I'm contemplating syntax between what belongs on the "Printer" side and what belongs on the "Print" side. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4177 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB8CkhQy8SFY0tn4LrDckEwhQnEBefFks5syHbigaJpZM4QNaTa> .

lordofhyphens · 2017-12-21T16:36:20Z

@goofdad prod

goofdad · 2017-12-21T16:38:31Z

Christmas...and a hypercube build. I'll beat my head on this again soon...

…

On Dec 21, 2017 8:36 AM, "Joseph Lenox" ***@***.***> wrote: @goofdad <https://github.com/goofdad> *prod* — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4177 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZBwLfRdGnIp1SGpQLkj6NTdnUkmlTYks5tCokNgaJpZM4QNaTa> .

lordofhyphens · 2017-12-21T21:45:21Z

'S okay. I have 53+ hours logged at work for the week so far.

…

On Dec 21, 2017 10:38 AM, "goofdad" ***@***.***> wrote: Christmas...and a hypercube build. I'll beat my head on this again soon... On Dec 21, 2017 8:36 AM, "Joseph Lenox" ***@***.***> wrote: > @goofdad <https://github.com/goofdad> *prod* > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#4177 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ AAZBwLfRdGnIp1SGpQLkj6NTdnUkmlTYks5tCokNgaJpZM4QNaTa> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4177 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB8CrNqxZoNDxNam9-2QDzi0qKf-BCkks5tComIgaJpZM4QNaTa> .

lordofhyphens · 2018-02-24T22:12:36Z

@goofdad still need those changes made to accept.

lordofhyphens · 2018-04-05T04:28:56Z

@goofdad :)

tcurdt · 2018-09-09T15:27:52Z

@goofdad any plans on making those changes? or should someone else take over?

lordofhyphens · 2019-01-06T21:57:08Z

@tcurdt Probably should take a swing and/or make PRs against his branch.

Add pause-at-layer functionality for 3092

83ff91f

goofdad mentioned this pull request Oct 31, 2017

Feature Request: Insert Pause and/or custom Gcode between layers in 3D preview #3092

Open

lordofhyphens requested changes Nov 1, 2017

View reviewed changes

lordofhyphens mentioned this pull request Nov 1, 2017

Custom Gcode UI Redesign #4178

Open

lordofhyphens assigned goofdad Dec 31, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pause-at-layer functionality for 3092 #4177

Add pause-at-layer functionality for 3092 #4177

goofdad commented Oct 31, 2017

lordofhyphens left a comment

lordofhyphens Nov 1, 2017

lordofhyphens Nov 1, 2017

lordofhyphens Nov 1, 2017

goofdad Nov 1, 2017

lordofhyphens Nov 1, 2017

lordofhyphens commented Nov 1, 2017

goofdad commented Nov 1, 2017

goofdad commented Nov 1, 2017

lordofhyphens commented Nov 1, 2017 •

edited

Loading

ledvinap commented Nov 1, 2017

goofdad commented Nov 1, 2017

lordofhyphens commented Nov 1, 2017 via email

lordofhyphens commented Dec 21, 2017

goofdad commented Dec 21, 2017 via email

lordofhyphens commented Dec 21, 2017 via email

lordofhyphens commented Feb 24, 2018

lordofhyphens commented Apr 5, 2018

tcurdt commented Sep 9, 2018

lordofhyphens commented Jan 6, 2019

Add pause-at-layer functionality for 3092 #4177

Are you sure you want to change the base?

Add pause-at-layer functionality for 3092 #4177

Conversation

goofdad commented Oct 31, 2017

lordofhyphens left a comment

Choose a reason for hiding this comment

Philosophical Questions

UI

lordofhyphens Nov 1, 2017

Choose a reason for hiding this comment

lordofhyphens Nov 1, 2017

Choose a reason for hiding this comment

lordofhyphens Nov 1, 2017

Choose a reason for hiding this comment

goofdad Nov 1, 2017

Choose a reason for hiding this comment

lordofhyphens Nov 1, 2017

Choose a reason for hiding this comment

lordofhyphens commented Nov 1, 2017

goofdad commented Nov 1, 2017

goofdad commented Nov 1, 2017

lordofhyphens commented Nov 1, 2017 • edited Loading

ledvinap commented Nov 1, 2017

goofdad commented Nov 1, 2017

lordofhyphens commented Nov 1, 2017 via email

lordofhyphens commented Dec 21, 2017

goofdad commented Dec 21, 2017 via email

lordofhyphens commented Dec 21, 2017 via email

lordofhyphens commented Feb 24, 2018

lordofhyphens commented Apr 5, 2018

tcurdt commented Sep 9, 2018

lordofhyphens commented Jan 6, 2019

lordofhyphens commented Nov 1, 2017 •

edited

Loading