Optimistic print time estimator #3747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… status bar change.
… sliced statistics.
…calculation methods.
…ox and to output gcode. Includes travel moves in xy, ignores retractions, cooling buffer, and anything that is set in the firmware that isn't immediately known to the slicer.
lordofhyphens
added
Feature request
|
Obviously it will be even less accurate if you're not telling Slic3r to control acceleration. |
…correctly on different platforms. Changed output units to cm/cm^3
alranel
requested changes
Mar 10, 2017
There was a problem hiding this comment.
This adds extra computation time and does not include things like retractions which are usually slow (as well as travel moves perhaps?).
I'd prefer to implement the time estimator as a separate G-code processor. The GUI could launch that computation asynchronously in a background thread and it would be much easier to account for every G-code line including retractions and travel moves. Also we would provide the community with an almost standalone, or at least cleaner, time estimation library. Unit testing (heuristics etc.) would be easier too.
|
I am very okay with that. Perhaps we can roll it into a more general plugin
arrangement instead? Something I have been mulling over.
|
alranel
added a commit
that referenced
this pull request
Mar 24, 2017
|
Superseded by 969f28f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optimistic print time estimator to Slic3r. Considers just the print and travel moves under ideal circumstances. The information is collected during gcode generation per-extruder and then summed at the end.
This PR requires that #3669 be merged first (adds slicing statistic box)
Implements #1766 (along with #3669).