Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retract when there is no a lower layer, like in the first layer. #3618

Closed
wants to merge 1 commit into from
Closed

Retract when there is no a lower layer, like in the first layer. #3618

wants to merge 1 commit into from

Conversation

xoan
Copy link
Member

@xoan xoan commented Dec 15, 2016

Not sure if this small addition is all the code needed to fix #3053, but it seems to work.

@xoan
Retract when there is no a lower layer
ab8d083 
like in the first layer.
lordofhyphens
lordofhyphens reviewed Dec 15, 2016
View reviewed changes
Copy link
Member

@lordofhyphens lordofhyphens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything mechanically wrong with this solution, although did you test it with a raft being printed?

alranel added a commit that referenced this pull request Dec 16, 2016
@alranel
Always retract in bottom layers. #3053 #3618
d4d26a5
@alranel
Copy link
Member

alranel commented Dec 16, 2016

I pushed a different change (more correct). But thank you for the input!

@alranel alranel closed this Dec 16, 2016
bubnikv referenced this pull request in prusa3d/PrusaSlicer Feb 21, 2017
@alranel @bubnikv
Always retract in bottom layers. #3053 #3618
a8edff1
@xoan xoan deleted the retract-on-first-layer branch March 23, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordofhyphens lordofhyphens lordofhyphens left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: retract on first layer
3 participants
@xoan @alranel @lordofhyphens