Extra perimeters detection includes extra perimeters. #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alranel
requested changes
Dec 16, 2016
| @@ -662,7 +662,7 @@ PrintObject::_make_perimeters() | |||
| this->typed_slices = false; | |||
| this->state.invalidate(posPrepareInfill); | |||
| } | |||
|
|
|||
| std::cerr << "Done merging slices" << std::endl; | |||
| for (Surfaces::iterator slice = layerm.slices.surfaces.begin(); | ||
| slice != layerm.slices.surfaces.end(); ++slice) { | ||
| while (true) { | ||
| // compute the total thickness of perimeters | ||
| const coord_t perimeters_thickness = ext_perimeter_width/2 + ext_perimeter_spacing/2 | ||
| + (region.config.perimeters-1 + region.config.extra_perimeters) * perimeter_spacing; | ||
| + (region.config.perimeters-1 + region.config.extra_perimeters + slice->extra_perimeters) * perimeter_spacing; |
There was a problem hiding this comment.
Oh, that's right!
And I clearly see my error at porting time: region.config.extra_perimeters is a boolean: it should not be summed in that expression! I wrote region.config.extra_perimeters instead of slice->extra_perimeters.
|
Oops indeed. I am away from my computers until probably Sunday or Monday;
you should have access though to change the commit yourself, or fix it
separately and close this :).
…On Dec 16, 2016 3:15 PM, "Alessandro Ranellucci" ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In xs/src/libslic3r/PrintObject.cpp
<#3614 (review)>:
> @@ -662,7 +662,7 @@ PrintObject::_make_perimeters()
this->typed_slices = false;
this->state.invalidate(posPrepareInfill);
}
-
+ std::cerr << "Done merging slices" << std::endl;
whoops ;)
------------------------------
In xs/src/libslic3r/PrintObject.cpp
<#3614 (review)>:
> for (Surfaces::iterator slice = layerm.slices.surfaces.begin();
slice != layerm.slices.surfaces.end(); ++slice) {
while (true) {
// compute the total thickness of perimeters
const coord_t perimeters_thickness = ext_perimeter_width/2 + ext_perimeter_spacing/2
- + (region.config.perimeters-1 + region.config.extra_perimeters) * perimeter_spacing;
+ + (region.config.perimeters-1 + region.config.extra_perimeters + slice->extra_perimeters) * perimeter_spacing;
Oh, that's right!
And I clearly see my error at porting time: region.config.extra_perimeters
is a boolean: it should not be summed in that expression! I wrote
region.config.extra_perimeters instead of slice->extra_perimeters.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#3614 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB8CoacCMg_gKLgNUgSf7A2ZvDb4FtKks5rIv9ggaJpZM4LLTGI>
.
|
alranel
added a commit
that referenced
this pull request
Dec 16, 2016
|
I fixed this directly, quicker... But gave you credits in the message ;) |
bubnikv
added a commit
to prusa3d/PrusaSlicer
that referenced
this pull request
Feb 2, 2017
Fixed by @alexr slic3r/Slic3r@8f0d8f2 See also slic3r/Slic3r#3613 slic3r/Slic3r#3614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3613
Would appreciate it if @bubnikv or @alexrj would check the one-line edit to see if I'm missing something critical about the extra perimeter detection.