Fix layer cooldown time #3303
Merged
Fix layer cooldown time #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent GCode writer changes which put the speed changes on a line of their own have caused the layer time slowdown to be ignored by the regex in CoolingBuffer.pm. Fixes: slic3r#3134
|
Is there a test case so I can see the difference between the effect of this PR and the previous setup? |
|
Issue is at #3134 |
When accumulating elapsed_time from many moves that take less than 1 second, elapsed_time does not get incremented because (unsigned int)0.9 = 0.
|
All checks are passing and it looks like it works and doesn't cause any other problems from my limited testing. Going to merge this in, @alexrj for 1.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent GCode writer changes which put the speed changes on a line of
their own have caused the layer time slowdown to be ignored by the regex
in CoolingBuffer.pm.