TypeHintDeclarationSniff: Fixed false positive

slevomat · Feb 3, 2019 · fdab228 · fdab228
1 parent ecb6084
commit fdab228
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/SlevomatCodingStandard/Sniffs/TypeHints/TypeHintDeclarationSniff.php b/SlevomatCodingStandard/Sniffs/TypeHints/TypeHintDeclarationSniff.php
@@ -240,6 +240,10 @@ private function checkParametersTypeHints(File $phpcsFile, int $functionPointer)
 
 					$possibleParameterTypeHint = $this->getTraversableTypeHintFromType($parameterTypeNode);
 					$nullableParameterTypeHint = false;
+
+					if (!$this->isTraversableType(TypeHintHelper::getFullyQualifiedTypeHint($phpcsFile, $functionPointer, $possibleParameterTypeHint))) {
+						continue;
+					}
 				}
 			}
 
@@ -464,6 +468,10 @@ private function checkReturnTypeHints(File $phpcsFile, int $functionPointer): vo
 
 				$possibleReturnTypeHint = $this->getTraversableTypeHintFromType($returnTypeNode);
 				$nullableReturnTypeHint = false;
+
+				if (!$this->isTraversableType(TypeHintHelper::getFullyQualifiedTypeHint($phpcsFile, $functionPointer, $possibleReturnTypeHint))) {
+					return;
+				}
 			}
 		}
 

diff --git a/tests/Sniffs/TypeHints/data/typeHintDeclarationNoErrors.php b/tests/Sniffs/TypeHints/data/typeHintDeclarationNoErrors.php
@@ -677,6 +677,21 @@ public function hasGenericReturnAnnotation(): \Traversable
 	{
 	}
 
+	/**
+	 * @param mixed[]|string $parameter
+	 */
+	public function parameterArrayOrString($parameter): void
+	{
+	}
+
+	/**
+	 * @return mixed[]|string
+	 */
+	public function returnsArrayOrString()
+	{
+		return [];
+	}
+
 }
 
 class IntersectionAndGeneric