Externalize dependencies in esm bundle

[bluwy]

Not sure if it's intentional, but since emoji-regex-xs, regex and regex-recursion is already part of the dependencies list, the bundled code could externalize them to import the packages as is.

[slevithan]

Thanks for the PR. It is intentional, but I'm open to feedback/change.

What are the benefits to externalizing? Is it simply that code that uses e.g. both Oniguruma-To-ES and Regex+ wouldn't duplicate any code? (Note that the bundled code from dependencies is fairly small, since Oniguruma-To-ES imports only regex/internals from Regex+.)

The advantage of the current setup is that the ESM bundle can be used directly in browsers.

[bluwy]

The dependencies are installed together when installing oniguruma-to-es, so it seems a bit off to me to not use them in the published code. If it's intended to bundle everything, I think the package should've moved those dependencies as devDependencies. If not, the developer would be installing duplicated/unused code.

But I think it's usually better to not bundle dependencies and have a setup like this PR. It's usually how npm packages are built. About browser support, I think the "browser" field points to a minified JS (which is not externalizing dependencies) so it's fine? Also for ESM entrypoints, CDNs like https://esm.sh can also handle externalized dependencies.

[slevithan]

Released in v0.9.0. 😊

[bluwy]

Thanks!