forked from ESCOMP/CTSM
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating externals_clm configuration to new tag #2
Merged
slevis-lmwg
merged 1 commit into
slevis-lmwg:lightning_v2_ctsm
from
glemieux:lightning_v2_ctsm-externals
Jul 23, 2020
Merged
Updating externals_clm configuration to new tag #2
slevis-lmwg
merged 1 commit into
slevis-lmwg:lightning_v2_ctsm
from
glemieux:lightning_v2_ctsm-externals
Jul 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevis-lmwg
pushed a commit
that referenced
this pull request
Nov 10, 2020
Adjust ice to liquid density in ice mass calculation Adjust ice to liquid density in ice mass calculation, as lake layer is not adjusted for change in density.
slevis-lmwg
pushed a commit
that referenced
this pull request
Feb 11, 2021
added timing calls to all subroutines in clmfates_interfaceMod.F90
slevis-lmwg
pushed a commit
that referenced
this pull request
Feb 11, 2021
Cleanup typo and empty logic set
slevis-lmwg
pushed a commit
that referenced
this pull request
Nov 23, 2021
LILACSMOKE test: point to a still-existing Macros.make
slevis-lmwg
pushed a commit
that referenced
this pull request
Mar 29, 2022
Ideally we would do year-2000 tests to have more crop cover and thus potentially be more useful tests. However, there are problems running a year-2000 ciso test with crop. These problems exist even with an SMS test on master: I tried tests like SMS_Ly1_P72x1.f10_f10_mg37.I2000Clm45BgcCrop.cheyenne_gnu.clm-ciso--clm-cropMonthOutput, but both debug & non-debug, intel & gnu versions. Debug tests fail like this (from SMS_D_Ly1_P72x1.f10_f10_mg37.I2000Clm45BgcCrop.cheyenne_gnu.clm-ciso--clm-cropMonthOutput): 30:Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation. 30: 30:Backtrace for this error: 13: 13:Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation. 13: 13:Backtrace for this error: 13:#0 0x2b9d1acc4aff in ??? 30:#0 0x2b9d1acc4aff in ??? 13:#1 0xf63fff in cisofluxcalc 13: at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNCIsoFluxMod.F90:1555 30:#1 0xf63fff in cisofluxcalc 30: at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNCIsoFluxMod.F90:1555 30:#2 0xf6b489 in __cncisofluxmod_MOD_cisoflux1 30: at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNCIsoFluxMod.F90:153 13:#2 0xf6b489 in __cncisofluxmod_MOD_cisoflux1 13: at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNCIsoFluxMod.F90:153 13:#3 0xe45657 in __cndrivermod_MOD_cndrivernoleaching 13: at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNDriverMod.F90:559 30:#3 0xe45657 in __cndrivermod_MOD_cndrivernoleaching 30: at /glade/work/sacks/ctsm_code/ctsm/src/biogeochem/CNDriverMod.F90:559 An intel test dies in the same place. Non-debug versions die like this (both for gnu and intel): 30: set_curr_delta ERROR: found unexpected non-zero delta mid-year 30: Dribbler name: hrv_xsmrpool_to_atm_c_13 30: i, delta = 2 NaN 30: Start of time step date (yr, mon, day, tod) = 2000 1 15 57600 30: This indicates that some non-zero flux was generated at a time step 30: other than the first time step of the year, which this dribbler was told not to expect. 30: If this non-zero mid-year delta is expected, then you can suppress this error 30: by setting allows_non_annual_delta to .true. when constructing this dribbler. 30:iam = 30: local gridcell index = 2 30:iam = 30: global gridcell index = 103 30:iam = 30: gridcell longitude = 285.0000000 30:iam = 30: gridcell latitude = -10.0000000 30: ENDRUN: 30: ERROR: set_curr_delta: found unexpected non-zero delta mid-year: ERROR in /glade/work/sacks/ctsm_code/ctsm/src/utils/AnnualFluxDr ibbler.F90 at line 276 So there is some issue with year-2000 ciso tests with crop. This issue exists on master, for clm45 and clm50 tests. (e.g., for clm50, I tried SMS_D_Ly1_P72x1.f10_f10_mg37.I2000Clm50BgcCrop.cheyenne_gnu.clm-ciso--clm-cropMonthOutput.)
slevis-lmwg
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ation Remove fates dependency on `do_harvest`
slevis-lmwg
pushed a commit
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the Externals_CLM.cfg to match the tag that I'll create for the corresponding fates PR.