Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize scalpel #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Dockerize scalpel #44

wants to merge 4 commits into from

Conversation

s4ros
Copy link

@s4ros s4ros commented Nov 2, 2020

No description provided.

docker run --rm -it \
-v ${PWD}/device.img:/scalpel/device.img \
-v ${PWD}/recovery:/scalpel/recovery \
s4ros/scalpel $@
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to sleuthkit

ERRORS+=("No ${PWD}/device.img file available!")
fi

# if [[ ! -d ${PWD}/recovery ]]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code should be removed before pushing to production

@@ -1,3 +1,26 @@
# s4ros/scalpel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to sleuthkit

docker run --rm -it \
-v $(pwd)/device.img:/scalpel/device.img \
-v $(pwd)/recovery:/scalpel/recovery \
s4ros/scalpel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to sleuthkit

@@ -1,3 +1,26 @@
# s4ros/scalpel

In courtesy of https://github.com/sleuthkit/scalpel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This segment should be removed, since this will actually be in the official sleuthkit repository

Comment on lines +5 to +6
RUN apt-get update && \
apt-get install -y -qq --no-install-recommends \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN apt-get update && \
apt-get install -y -qq --no-install-recommends \
RUN apt update && \
apt install -y -qq --no-install-recommends \

it's time to let go of apt-get

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt-get should still be used in scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants