added short_name to administrative_area #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawek87
added a commit
that referenced
this pull request
Oct 21, 2015
added short_name to administrative_area
|
nice work! I merged your request :) |
|
btw. can you update README.md and add there info about short_name? :) (CONTRIBUTORS file also! :) ) |
|
ok great! |
|
yes.. make pull request :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
nice work. I like the module.
For my project, I would need to retrieve also the short_name of the administrative area. I added that functionality (+test) in this pull request. Let me know if you can consider it.
Thanks