-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: API Version support #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishorereddy
added
priority_high
high priority
effort_high
high effort
feature
new feature request
labels
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support for versions on APIs. This includes a hybrid approach to supporting versions.
Ticket(s)
This mainly fixes issue 359 below for supporting versions in Kiit APIs. However, it also has support for 325 as well.
Links(s)
See this blog post about global version as that is supported in the PR/solution.
Dependencies
The only dependency added is the org.json.simple JSON parser.
Design
See details in ticket above, examples include
{version}/{area}/{api}/{action}
v1/accounts/signup/login
Notes
Pending
There is a separate issue regarding custom parameter types loaded from the request as part of deserialization. This is going to be handled in a separate ticket.
Tests