Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Sming version information into SmingVersion.h #31

Merged
merged 2 commits into from
Oct 11, 2019

Conversation

mikee47
Copy link

@mikee47 mikee47 commented Oct 11, 2019

Define version components separately and include pre-release tag.

@mikee47
Copy link
Author

mikee47 commented Oct 11, 2019

For release builds we have two options:

#define SMING_PRE_RELEASE (a)
or
#define SMING_PRE_RELEASE "" (b)

I'm thinking (a).

@slaff
Copy link
Owner

slaff commented Oct 11, 2019

@mikee47 Shall I merge this PR or you want some time to add more changes ?

@mikee47
Copy link
Author

mikee47 commented Oct 11, 2019

All done thanks.

@slaff slaff merged commit f221554 into slaff:release/4.0.0-rc2 Oct 11, 2019
slaff added a commit that referenced this pull request Oct 17, 2019
* Initial refactoring of the readme in preparation for Sming v4.0.0
* NON-OS SDK 3.0.1 is now the default SDK for Sming for the ESP8266 architecture.
Users can still switch to their preferred SDK by setting
the environment variable SDK_BASE to point to the location of their SDK.

For Linux that used to be

   export SDK_BASE=$ESP_HOME/sdk

And for Windows that used to be

   set SDK_BASE=$ESP_HOME/ESP8266_SDK

* Simplify the CI system and support officially only NON-OS SDK >= 3.0.1.

* Added TOC

* Don't compile basic blink before the coverity scan.
Otherwise the compiled code will not be included in the static code analysis results.

* Move Sming version information into `SmingVersion.h` (#31)

* Move Sming version information into `SmingVersion.h` and update to include pre-release tag

* 4.0.0-rc2

[scan:coverity]
@mikee47 mikee47 deleted the update/sming-version branch October 17, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants