Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding RoCEv2 support to the SURF Ethernet library #1192

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Adding RoCEv2 support to the SURF Ethernet library #1192

merged 6 commits into from
Oct 14, 2024

Conversation

ruck314
Copy link
Contributor

@ruck314 ruck314 commented Sep 18, 2024 •
edited
Loading

@ruck314 ruck314 marked this pull request as ready for review September 19, 2024 16:27
@ruck314 ruck314 mentioned this pull request Sep 23, 2024
Merged
@FilMarini
Copy link
Collaborator

Hi @ruck314 ,
sorry this is taking a bit long to review. I've been away for a few days for a conference and other stuff. I'm planning to get to this soon.

@FilMarini
Copy link
Collaborator

I've resolved the errors in the code and I also went ahead and changed the location of th RoCEv2 folder, merging it with the RoceEngine folder in ethernet

Let me know if you agree with the changes, otherwise we can always move it back

@ruck314
Copy link
Contributor Author

ruck314 commented Oct 10, 2024

@FilMarini I agree with the changes. When you think we are ready, please approve the PR and I will merge the PR.

@ruck314 ruck314 mentioned this pull request Oct 10, 2024
Merged
FilMarini
FilMarini approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@FilMarini FilMarini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've implemented the branch in hw (KCU105) and got the same results as my previous tests using my personal repo: ~9.7 Gbps of throughput to a ConnectX-5

@ruck314 ruck314 merged commit a9d3b2f into pre-release Oct 14, 2024
3 checks passed
@ruck314 ruck314 deleted the EthMacCore-RoCEv2 branch October 14, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilMarini FilMarini FilMarini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruck314 @FilMarini