Project approval history #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a limit is a good idea. We can arbitrarily set the limit to 100 now and reconsider later |
tangkong
reviewed
Nov 27, 2024
Comment on lines
+909
to
+913
| licco_db[line_config_db_name]["switch"].insert_one({ | ||
| "prj": ObjectId(prjid), | ||
| "requestor_uid": project_submitter, | ||
| "switch_time": datetime.datetime.utcnow() | ||
| }) |
There was a problem hiding this comment.
Do we want to try and populate the other fields expected by the rest of the app?
licco/react/src/app/projects/project_model.tsx
Lines 366 to 373 in c8d432c
There was a problem hiding this comment.
When we query the data (get_projects_approval_history method), the missing data is populated with the data from the projects table (owner, description, project name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approval history endpoint is now returning data.
Q: Should we limit the maximum number of returned approvals to some reasonable number (e..g, last 100 approvals)? Otherwise with enough time we may end up with returning too much data for the frontend to handle (most of which the user is not even interested in).