-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cron for SlackHQ Upstream Sync action #4
Conversation
Add repo sync GitHub Action
Signed-off-by: Tim Vaillancourt <[email protected]>
Stop syncing release-* branches
Signed-off-by: Tim Vaillancourt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few Qs just so I understand how this works:
- is the other repo now responsible for the sync of this repo?
- if ^^^ is true, do we still need
.github/workflows/slackhq_upstream_sync.yml
, or this is just a quick test?
@vmogilev I'm testing two approaches at the moment:
I'd like to keep both approaches while we decide which is best. For now disabling the cron schedule will prevent them from fighting each other cc @tanjinx |
|
|
Closing as the repo sync moved to a new repo |
* decouple olap tx timeout from oltp tx timeout Since workload=olap bypasses the query timeouts (--queryserver-config-query-timeout) and also row limits, the natural assumption is that it also bypasses the transaction timeout. This is not the case, e.g. for a tablet where the --queryserver-config-transaction-timeout is 10. This commit: * Adds new CLI flag and YAML field to independently configure TX timeouts for OLAP workloads (--queryserver-config-olap-transaction-timeout). * Decouples TX kill interval from OLTP TX timeout via new CLI flag and YAML field (--queryserver-config-transaction-killer-interval). Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #1 Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #2 consolidate timeout logic in sc Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: remove unused tx killer flag Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: update 15_0_0_summary.md Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: fix race cond Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #3 -txProps.timeout, +sc.expiryTime Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #4 -atomic.Value for expiryTime Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: fix race cond (without atomic.Value) Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #5 -unused funcs, fix comments, set ticks interval once Signed-off-by: Max Englander <[email protected]> * decouple ol{a,t}p tx timeouts: pr comments #5 +txkill tests Signed-off-by: Max Englander <[email protected]> * revert fmt changes Signed-off-by: Max Englander <[email protected]> * implement pr review suggestion Signed-off-by: Max Englander <[email protected]> Signed-off-by: Max Englander <[email protected]>
Description
This PR stops the
SlackHQ Upstream Sync
action from running on a cron schedule so it doesn't fight a POC being tested at https://github.com/slackhq/vitess-repo-syncer