This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Added user-settable numberOfLines for placeholderLabel #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jedmund. |
|
Done and done @dzenbot. Is the Travis CI build something I should worry about? Thanks! |
| @@ -138,7 +138,6 @@ - (UILabel *)placeholderLabel | |||
| _placeholderLabel = [UILabel new]; | |||
| _placeholderLabel.clipsToBounds = NO; | |||
| _placeholderLabel.autoresizesSubviews = NO; | |||
| _placeholderLabel.numberOfLines = 1; | |||
There was a problem hiding this comment.
@jedmund Sup yo?, Sweet PR, you should keep this line though so that default number of lines is 1 as per the documentation you wrote.
|
Thanks @TosinAF! I knew something looked off. Added it back just now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added property to allow the user to set how many lines of text
SLKTextView's placeholder should have.Related Issues
This fixes issue #504.