-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SocketModeClient expose async event loop param #1609
Conversation
Thanks for the contribution! Before we can merge this, we need @jantman to sign the Salesforce Inc. Contributor License Agreement. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1609 +/- ##
=======================================
Coverage 84.93% 84.93%
=======================================
Files 113 113
Lines 12629 12630 +1
=======================================
+ Hits 10726 10727 +1
Misses 1903 1903 ☔ View full report in Codecov by Sentry. |
@jantman looks like although the CI checks passed, 3.11 and 3.12 are returning annotations of runtime testing errors: |
@hello-ashleyintech Thanks for checking this. It seems the warning/error logs can occur without this PR's changes. So, the unit tests might need to be improved, but there is no need to check its details this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this PR! While there are a few things to tweak such as docstring comment updates and adding unit tests, the change looks good to me. I will update the missing ones after merging this PR.
Summary
This PR exposes the
loop
(asyncio event loop) parameter of the async SocketModeClient, so that the socket mode client can be used inside an existing asyncio event loop.Testing
Ensure that the parameter is actually passed through? This is a rather trivial change just to expose a parameter that currently isn't.
Category
/docs
(Documents)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.