-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: ensure consistent behavior around url format #1600
tests: ensure consistent behavior around url format #1600
Conversation
I think the |
@WilliamBergamin How about simply spinning a mock web server up and verifying the request path on the mock server side? We have some test utilities doing so, so it'd be much easier to set up. |
@seratch this was my original approach but it seemed like the mock server did not support verifying the request path I've brought over some changes we applied to the mock server in the bolt project, this resolved the issue 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilliamBergamin Merging #1602 before this caused git conflicts on this PR. Once they're resolved, this PR looks great to me
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
+ Coverage 84.89% 84.91% +0.01%
==========================================
Files 113 113
Lines 12622 12622
==========================================
+ Hits 10716 10718 +2
+ Misses 1906 1904 -2 ☔ View full report in Codecov by Sentry. |
Summary
This PR adds unit test that validate the url used to send a request to Slack.
Testing
NA
Category
/docs
(Documents)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.