Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add team.externalTeams.disconnect #1526

Merged

Conversation

WilliamBergamin
Copy link
Contributor

Summary

This PR adds support for the team.externalTeams.disconnect method

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@WilliamBergamin WilliamBergamin added enhancement M-T: A feature request for new functionality semver:minor web-client Version: 3x labels Jul 3, 2024
@WilliamBergamin WilliamBergamin added this to the 3.30.1 milestone Jul 3, 2024
@WilliamBergamin WilliamBergamin requested review from seratch and filmaj July 3, 2024 18:33
@WilliamBergamin WilliamBergamin self-assigned this Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (40f7a57) to head (67405f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
+ Coverage   84.88%   85.01%   +0.13%     
==========================================
  Files         113      113              
  Lines       12489    12498       +9     
==========================================
+ Hits        10601    10625      +24     
+ Misses       1888     1873      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; once you resolve the conflict, go ahead with merging this

@WilliamBergamin WilliamBergamin merged commit 41467d7 into slackapi:main Jul 4, 2024
12 checks passed
@WilliamBergamin WilliamBergamin deleted the team.externalTeams.disconnect branch July 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants