Replace Flask-Sockets with aiohttp for testing #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flask-Sockets is deprecated and it won't receive any fixes in the future, so it seems reasonable to replace it with some up-to-date library. aiohttp has been chosen since it was already presented as an optional requirement. These changes also: * move format checking for tests from run_validation.sh to setup.py * remove duplicated dependency installations from setup.py * add a codegen step on CI * force colors on CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
==========================================
+ Coverage 85.60% 85.64% +0.04%
==========================================
Files 111 111
Lines 12128 12128
==========================================
+ Hits 10382 10387 +5
+ Misses 1746 1741 -5 ☔ View full report in Codecov by Sentry. |
seratch
approved these changes
Dec 24, 2023
|
@WilliamBergamin you can follow this for your new project |
|
Yess definitely this is awesome work 💯 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @seratch,
I hope you may find this PR useful.
Summary
Flask-Socketsis deprecated and it won't receive any fixes in the future, so it seems reasonable to replace it with some up-to-date library.aiohttphas been chosen since it was already presented as an optional requirement.These changes also:
run_validation.shtosetup.pysetup.pycodegenstep on CICategory (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.Best regards!