Skip to content

Commit

Permalink
build: enable tests that are no longer unstable (#1617)
Browse files Browse the repository at this point in the history
  • Loading branch information
WilliamBergamin authored Dec 17, 2024
1 parent 4dfcbf5 commit 6ca12d0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
- "pypy3.10"
env:
CI_LARGE_SOCKET_MODE_PAYLOAD_TESTING_DISABLED: "1"
CI_UNSTABLE_TESTS_SKIP_ENABLED: "1"
FORCE_COLOR: "1"
steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 0 additions & 4 deletions tests/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,3 @@ def remove_os_env_temporarily() -> dict:

def restore_os_env(old_env: dict) -> None:
os.environ.update(old_env)


def is_ci_unstable_test_skip_enabled() -> bool:
return os.environ.get("CI_UNSTABLE_TESTS_SKIP_ENABLED") == "1"
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

from slack_sdk import WebClient
from slack_sdk.socket_mode.websocket_client import SocketModeClient
from tests.helpers import is_ci_unstable_test_skip_enabled
from tests.slack_sdk.socket_mode.mock_socket_mode_server import (
start_socket_mode_server,
socket_mode_envelopes,
Expand Down Expand Up @@ -90,10 +89,6 @@ def socket_mode_request_handler(client: BaseSocketModeClient, request: SocketMod
client.close()

def test_send_message_while_disconnection(self):
if is_ci_unstable_test_skip_enabled():
# this test tends to fail on the GitHub Actions platform
return

try:
client = SocketModeClient(
app_token="xapp-A111-222-xyz",
Expand Down

0 comments on commit 6ca12d0

Please sign in to comment.