Update webhook and web-api dependencies in oauth, rtm-api, and socket-mode #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 38 38
Lines 10317 10317
Branches 647 647
=======================================
Hits 9457 9457
Misses 848 848
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
WilliamBergamin
requested changes
Dec 9, 2024
packages/client/package.json
Outdated
Comment on lines
51
to
52
| "@slack/web-api": "^7.8.0", | ||
| "@slack/webhook": "^7.0.4" |
There was a problem hiding this comment.
I think we don't support the @slack/client anymore but I'm not sure what this means for security update 🤔
I think this major update might be a breaking change, the client test strategy might be insufficient to detect this
There was a problem hiding this comment.
ahhhh yes yes, you're right! 🙌 it's also marked as deprecated on npm, so I'll revert these changes!
hello-ashleyintech
changed the title
zimeg
added
semver:patch
pkg:rtm-api
zimeg
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With medium security vulns upgrades causing version bumps in
webhookandweb-api(#2118), we can now update other packages that have these dependencies to the latest!Once this PR is merged and
rtm-api,oauth, andsocket-modepatch versions are released,bolt-jswill be updated with the latest versions of each of these.Requirements (place an
xin each[ ])