-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return runtime versions used by the application with a doctor hook #1763
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
41d62ac
feat: return runtime versions used by the application with a doctor hook
zimeg 50fc57b
feat: include the doctor hook in the initial get-hooks response
zimeg 9ca3be4
docs: document the doctor hook as a supported hook
zimeg f10f04a
chore: bump the minor version of this package early
zimeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
#!/usr/bin/env node | ||
|
||
import { fileURLToPath } from 'url'; | ||
import fs from 'fs'; | ||
|
||
import { getProtocol } from './protocols.js'; | ||
|
||
/** | ||
* Implementation of the optional doctor script hook for the Slack CLI. | ||
* Printed as an object containing information about the system runtime. | ||
*/ | ||
|
||
if (fs.realpathSync(process.argv[1]) === fileURLToPath(import.meta.url)) { | ||
const protocol = getProtocol(process.argv.slice(1)); | ||
protocol.respond(JSON.stringify(doctor())); // eslint-disable-line no-console | ||
} | ||
|
||
/** | ||
* Standardized communication format between the SDK and CLI regarding runtimes. | ||
* @typedef DoctorResponse | ||
* @property {RuntimeVersion[]} versions - Existing system dependencies present. | ||
*/ | ||
|
||
/** | ||
* Information about all of the installed runtime dependencies. | ||
* @typedef RuntimeVersion | ||
* @property {string} name - Name of the runtime dependency. | ||
* @property {string} current - Version found on the system. | ||
*/ | ||
|
||
/** | ||
* Contains available hooks and other configurations available to the SDK. | ||
* @returns {DoctorResponse} Information about the hooks currently supported. | ||
*/ | ||
export default function doctor() { | ||
return { | ||
versions: [ | ||
{ | ||
name: 'node', | ||
current: process.versions.node, | ||
}, | ||
{ | ||
name: 'v8', | ||
current: process.versions.v8, | ||
}, | ||
{ | ||
name: 'modules', | ||
current: process.versions.modules, | ||
}, | ||
], | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { describe, it } from 'mocha'; | ||
import assert from 'assert'; | ||
|
||
import doctor from './doctor.js'; | ||
|
||
describe('doctor implementation', async () => { | ||
it('should return versions of runtime dependencies', async () => { | ||
const { versions } = doctor(); | ||
assert(versions[0].name === 'node'); | ||
assert(versions[0].current === process.versions.node); | ||
assert(versions[1].name === 'v8'); | ||
assert(versions[1].current === process.versions.v8); | ||
assert(versions[2].name === 'modules'); | ||
assert(versions[2].current === process.versions.modules); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look Ma, no build step!
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪 🤧