Add rich text types #1643
Merged
Add rich text types #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmaj
suggested changes
Aug 24, 2023
There was a problem hiding this comment.
Hey @chrisronline left a few comments, and also rebased your branch with the latest main now that I fixed the build 😅 . Also our CI failed, I guess it doesn't like using object type and wants to use Record<string, any> or some such.
filmaj
force-pushed
the
add_rich_text
branch
from
b5b4963 to
b374882
Compare
… used to compose rich text messages. Add incremental RichTextBlock, Section and List.
filmaj
force-pushed
the
add_rich_text
branch
from
b374882 to
77b8fa9
Compare
filmaj
force-pushed
the
add_rich_text
branch
from
77b8fa9 to
a09e25f
Compare
filmaj
approved these changes
Sep 29, 2023
|
BTW I integrated this with the web-api and bolt-js projects and all the tests passed OK 👍 |
misscoded
approved these changes
Sep 29, 2023
Love the degree of commenting; makes everything super clear!
2 tasks
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds types for the
rich_textblock and many rich text elements, with the main one beingrich_text_input, but many others that make up rich text messages (text, links, user/channel/group mentions, preformatted text, quotes, lists - everything in the message composer).