Use Readable instead of ReadStream in uploadV2 #1577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The old
upload
method accepts aReadable
for its file argument, but the newuploadV2
accepts aReadStream
. There is no reason to useReadStream
here:Readable
is strictly more generic (it's a superclass ofReadStream
) and the code actually does not use any functionality specific toReadStream
, it only uses methods and events fromReadable
. This will make the transition fromupload
touploadV2
more easy.Requirements (place an
x
in each[ ]
)