Allow handlerInstallPath to work without stateStore
#1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockingskier
force-pushed
the
install-path-handler
branch
from
a06a2bf to
bcb3086
Compare
seratch
requested changes
Jul 3, 2022
| } else if (typeof existingCookies === 'string') { | ||
| allCookies.push(existingCookies); | ||
| let state; | ||
| if (this.stateStore) { |
There was a problem hiding this comment.
Can you use this.stateVerification flag instead and place L340 - L342 that you've deleted inside the if statement?
Suggested change
| if (this.stateStore) { | |
| if (this.stateVerification) { |
There was a problem hiding this comment.
I did that initially but it makes TS sad due to this.stateStore being optional.
I can do:
if (this.stateStore)- `if(this.stateVerification && this.stateStore)
await this.stateStore?.generateStateParambut this gets complicated asstatethen becomes optional
There was a problem hiding this comment.
How about doing like this? I would like the logic to check if this.stateVerification is true first.
if (this.stateVerification) {
if (this.stateStore) {
// the normal pattern
} else {
// have the codes L340 - L342
}
}There was a problem hiding this comment.
Sounds good 👍 Done.
seratch
added
bug
rockingskier
force-pushed
the
install-path-handler
branch
from
bcb3086 to
905f3e2
Compare
seratch
requested changes
Jul 7, 2022
rockingskier
force-pushed
the
install-path-handler
branch
from
905f3e2 to
72b3213
Compare
|
Sorted my local env and now I'm not coding blind :) Fixed, tests passing locally. Hopefully all good to go. |
seratch
approved these changes
Jul 7, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1506
This is a bit of a guess. It worked when I edited the compiled code in my
node_modules🤮 but I wouldn't be surprised if there was a better way :)I can't run the tests locally so I'm fully expecting them to fail. This is more of a "here's what I found" PR.
Requirements (place an
xin each[ ])