npm link up the packages in this repo during CI (#1672)

slackapi · Oct 6, 2023 · c7c2f44 · c7c2f44
1 parent 5c52029
commit c7c2f44
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml
@@ -26,4 +26,11 @@ jobs:
       working-directory: ${{ matrix.package }}
       run: |
         npm install || npm list
+        # depending on which package we are testing, also npm link up other dependent packages
+        case "$PWD" in
+          */webhook) pushd ../types && npm i && popd && npm link ../types;;
+          */web-api) pushd ../types && npm i && popd && npm link ../types && pushd ../logger && npm i && popd && npm link ../logger;;
+          # TODO: add oauth and socket-mode here once those packages have new major versions released
+          *) ;; # default
+        esac
         npm test
diff --git a/packages/web-api/src/WebClient.ts b/packages/web-api/src/WebClient.ts
@@ -406,7 +406,6 @@ export class WebClient extends Methods {
    * URLs returned from step 1 (e.g. https://files.slack.com/upload/v1/...\")
    * 
    * **#3**: Complete uploads {@link https://api.slack.com/methods/files.completeUploadExternal files.completeUploadExternal}
-   * 
    * @param options
    */
   public async filesUploadV2(options: FilesUploadV2Arguments): Promise<WebAPICallResult> {