Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edited property to AppMentionEvent class #755

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 5, 2021

As pointed out at slackapi/bolt-js#960 , an app_mention event payload can have edited property as with message event payloads.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to the those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-model project:slack-api-model project:slack-app-backend labels Jun 5, 2021
@seratch seratch added this to the 1.8.2 milestone Jun 5, 2021
@seratch seratch force-pushed the edited-in-app-mention-event branch from 79590b1 to 1a7ad28 Compare June 5, 2021 09:12
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #755 (1a7ad28) into main (7de2eb8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #755   +/-   ##
=========================================
  Coverage     77.42%   77.42%           
  Complexity     3303     3303           
=========================================
  Files           370      370           
  Lines          9807     9807           
  Branches        935      935           
=========================================
  Hits           7593     7593           
  Misses         1662     1662           
  Partials        552      552           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de2eb8...1a7ad28. Read the comment docs.

@seratch seratch merged commit 398c8ec into slackapi:main Jun 7, 2021
@seratch seratch deleted the edited-in-app-mention-event branch June 7, 2021 01:32
@seratch seratch modified the milestones: 1.8.2, 1.9.0 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-model project:slack-api-model project:slack-app-backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant