Add support for Dialog Select Datasource. #440

favalos · 2020-04-30T01:00:23Z

Add support for most recent changes to Dialog Select component.

I created an issue to keep track of this change:
Add support for Dynamic Select in Dialogs. #439

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.

CLAassistant · 2020-04-30T01:00:32Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ favalos
❌ Fernando Avalos

Fernando Avalos seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov · 2020-04-30T01:07:56Z

Codecov Report

Merging #440 into master will increase coverage by 0.00%.
The diff coverage is 90.00%.

@@            Coverage Diff            @@
##             master     #440   +/-   ##
=========================================
  Coverage     83.88%   83.89%           
- Complexity     2367     2369    +2     
=========================================
  Files           249      250    +1     
  Lines          6366     6376   +10     
  Branches        578      578           
=========================================
+ Hits           5340     5349    +9     
- Misses          672      673    +1     
  Partials        354      354

Impacted Files	Coverage Δ	Complexity Δ
...m/slack/api/model/dialog/DialogDataSourceType.java	`90.00% <90.00%> (ø)`	`2.00 <2.00> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4a2c5...d985db9. Read the comment docs.

seratch · 2020-04-30T02:58:40Z

json-logs/raw/audit/v1/actions.json

@@ -147,7 +147,8 @@
      "external_shared_channel_disconnected",
      "external_shared_channel_reconnected",
      "channel_moved",
-      "channel_renamed"
+      "channel_renamed",
+      "channel_posting_pref_changed_from_org_level"


We'd like to commit this separately. Please remove this change.

seratch · 2020-04-30T02:58:48Z

json-logs/raw/status/api/v1.0.0/current.json

@@ -213,6 +213,14 @@
    {
      "date_created": "2020-04-24T14:59:53-07:00",
      "body": "Some people may be having an issue with Slack. We’re currently investigating and will have more information shortly. Thank you for your patience."
+    },


same as above

seratch · 2020-04-30T02:59:00Z

json-logs/samples/scim/v1/ServiceProviderConfigs.json

-  "xmlDataFormat": {
-    "supported": false
-  }
+  ]


same as above

seratch · 2020-04-30T03:01:03Z

slack-api-model/src/test/java/test_locally/api/model/dialog/DialogsTest.java

+                    dialogTextArea(dta -> dta.subtype(DialogSubType.NUMBER))
+            ));
+        });
+        System.out.println(dialog.toString());


Remove this stdout printing. It's ideal if we could add more tests for external data source. But it's totally fine to merge your contribution without it. I can work on it in addition to yours afterward.

seratch · 2020-04-30T03:01:16Z

@favalos Thanks for taking the time to report the issue and make this PR!

To sign our CLA, could you follow the instructions below?

git reset HEAD~1
git add . -v
git config user.email {your github email address}
git commit -m'{your commit message}'
git push origin master

Once you've signed the CLA, I'm happy to fix the above by adding more commits in addition to your changes for you.

favalos · 2020-04-30T04:27:57Z

@seratch I did the changes requested. There are only four files changes in the pull request now.

Thanks and let me know if I can help to add more test cases.

seratch · 2020-04-30T06:46:14Z

I've merged your change by 0bd925f and a14cb63

Thanks a lot for your contribution!

@seratch

* [slack-api-client] #444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch * [slack-api-model] #441 #442 Fix Block Elements' object equality issues - thanks @eamelink * [slack-api-client] #445 #448 Add admin.usergroups.* API supports - thanks @seratch * [slack-api-model] #440 Add external data source supports for dialogs - thanks @favalos * [slack-api-model] #437 Update composition.OptionObject to have mrkdwn - thanks @seratch * [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch * [slack-api-model] #449 Add attachement.author_id - thanks @seratch * [slack-app-backend] #446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch * [slack-api-client etc] #444 #450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch

@seratch

* [slack-api-client] slackapi#444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch * [slack-api-model] slackapi#441 slackapi#442 Fix Block Elements' object equality issues - thanks @eamelink * [slack-api-client] slackapi#445 slackapi#448 Add admin.usergroups.* API supports - thanks @seratch * [slack-api-model] slackapi#440 Add external data source supports for dialogs - thanks @favalos * [slack-api-model] slackapi#437 Update composition.OptionObject to have mrkdwn - thanks @seratch * [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch * [slack-api-model] slackapi#449 Add attachement.author_id - thanks @seratch * [slack-app-backend] slackapi#446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch * [slack-api-client etc] slackapi#444 slackapi#450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch

Add support for Dialog Select Datasource.

b6f68d3

seratch requested changes Apr 30, 2020

View reviewed changes

seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-api-model project:slack-api-model project:slack-app-backend labels Apr 30, 2020

favalos added 2 commits April 29, 2020 21:07

ISSUE #439: Add support for Dynamic Select in Dialogs.

42aba6b

ISSUE #439: Add support for Dynamic Select in Dialogs.

d985db9

seratch closed this Apr 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Dialog Select Datasource. #440

Add support for Dialog Select Datasource. #440

favalos commented Apr 30, 2020

CLAassistant commented Apr 30, 2020 •

edited

Loading

codecov bot commented Apr 30, 2020 •

edited

Loading

seratch Apr 30, 2020

seratch Apr 30, 2020

seratch Apr 30, 2020

seratch Apr 30, 2020

seratch commented Apr 30, 2020

favalos commented Apr 30, 2020

seratch commented Apr 30, 2020

Add support for Dialog Select Datasource. #440

Add support for Dialog Select Datasource. #440

Conversation

favalos commented Apr 30, 2020

CLAassistant commented Apr 30, 2020 • edited Loading

codecov bot commented Apr 30, 2020 • edited Loading

Codecov Report

seratch Apr 30, 2020

Choose a reason for hiding this comment

seratch Apr 30, 2020

Choose a reason for hiding this comment

seratch Apr 30, 2020

Choose a reason for hiding this comment

seratch Apr 30, 2020

Choose a reason for hiding this comment

seratch commented Apr 30, 2020

favalos commented Apr 30, 2020

seratch commented Apr 30, 2020

CLAassistant commented Apr 30, 2020 •

edited

Loading

codecov bot commented Apr 30, 2020 •

edited

Loading