Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra double quotes from the "Add to Slack" OAuth image alt text #1380

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Sep 30, 2024

Summary

This PR removes extra double quotes from the "Add to Slack" OAuth image alt text to match similar changes made in slackapi/bolt-python#1170 and slackapi/node-slack-sdk#2044 🔍

From another comment, I believe the current snippet is changing the following in browser:

- <img alt=""example"" />
+ <img alt="" />

But using the single set of double quotes brings the alt text back 🙏 ✨

Category

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:bolt labels Sep 30, 2024
@zimeg zimeg added this to the 1.44.0 milestone Sep 30, 2024
@zimeg zimeg requested a review from seratch September 30, 2024 22:10
@zimeg zimeg self-assigned this Sep 30, 2024
@zimeg zimeg changed the title Remove extra double quotes from the "Add to Slack" oauth image alt text Remove extra double quotes from the "Add to Slack" OAuth image alt text Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (c8ce619) to head (a96d456).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1380   +/-   ##
=========================================
  Coverage     74.53%   74.53%           
  Complexity     4324     4324           
=========================================
  Files           472      472           
  Lines         13491    13491           
  Branches       1377     1377           
=========================================
  Hits          10056    10056           
  Misses         2622     2622           
  Partials        813      813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks!

@seratch seratch merged commit d085a0e into slackapi:main Sep 30, 2024
6 checks passed
@zimeg zimeg deleted the oauth-fix-alt-text-quotes branch September 30, 2024 23:45
@zimeg
Copy link
Member Author

zimeg commented Sep 30, 2024

@seratch Thank you for the review! And thanks @toofishes for finding this fix in the first place 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:bolt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants