Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add View to BlockSuggestionPayload #422

Closed
4 of 7 tasks
zolstein opened this issue Apr 6, 2020 · 1 comment · Fixed by #423
Closed
4 of 7 tasks

Add View to BlockSuggestionPayload #422

zolstein opened this issue Apr 6, 2020 · 1 comment · Fixed by #423
Labels
enhancement M-T: A feature request for new functionality project:bolt project:slack-app-backend

Comments

@zolstein
Copy link

zolstein commented Apr 6, 2020 •
edited
Loading

Issue Type

  • Bug
  • Enhancement / Feature request
  • Question
  • Documentation

Description

Add View to BlockSuggestionPayload

BlockSuggestionPayload class doesn't define the View field that gets passed when
a block_suggestion request comes from a view. As a result, code that handles a
block_suggestion request has to parse the View and pass it around with the BlockSuggestionPayload separately.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-app-backend labels Apr 7, 2020
seratch added a commit to seratch/java-slack-sdk that referenced this issue Apr 7, 2020
@seratch
Fix slackapi#422 Add View to BlockSuggestionPayload
b46bd34
@seratch seratch mentioned this issue Apr 7, 2020
Merged
2 tasks
@zolstein
Copy link
Author

zolstein commented Apr 7, 2020

Thanks so much for the quick turnaround.

seratch added a commit that referenced this issue Apr 7, 2020
@seratch
Merge pull request #423 from seratch/issue-422
81201f7 
Fix #422 Add View to BlockSuggestionPayload
seratch added a commit that referenced this issue Apr 8, 2020
@seratch
version 1.0.4
38f0757 
* [slack-api-model] Fix #422 Add View to BlockSuggestionPayload - thanks @zolstein @seratch
* [bolt-aws-lambda] Fix #419 Enable access to App in SlackApiLambdaHandler - thanks @acm19 @seratch
* [slack-api-model] Add style to rich_text emoji elements - thanks @seratch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement M-T: A feature request for new functionality project:bolt project:slack-app-backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #422 Add View to BlockSuggestionPayload seratch/java-slack-sdk
2 participants
@seratch @zolstein