Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option to ignore events by other workspace users in shared channels #593

Closed
4 of 9 tasks
seratch opened this issue Apr 24, 2020 · 1 comment · Fixed by #597
Closed
4 of 9 tasks

New option to ignore events by other workspace users in shared channels #593

seratch opened this issue Apr 24, 2020 · 1 comment · Fixed by #597
Assignees
Labels
enhancement M-T: A feature request for new functionality semver:minor
Milestone

Comments

@seratch
Copy link
Member

seratch commented Apr 24, 2020

Description

When this project started, Slack was not yet providing shared channels.

It's not supposed to invite Hubot users to shared channels but it may unintentionally happen. To avoid some confusion among end-users, it would be great if this project provides an option to turn off reacting to other workspace users.

The default behavior will be the same. Developers can turn off reacting to other workspace users by configuring Hubot apps.

I've already verified seratch@3190bac works as I expect in shared channels. I will come up with a pull request with a new option named INSTALLED_TEAM_ONLY.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added semver:minor enhancement M-T: A feature request for new functionality labels Apr 24, 2020
@seratch seratch self-assigned this Apr 24, 2020
@seratch seratch modified the milestones: 4.8.0, 4.9.0 Apr 24, 2020
@seratch
Copy link
Member Author

seratch commented Apr 28, 2020

I'm a bit busy with https://github.com/slackapi/python-slackclient this week and probably next week. After finishing those Python tasks, I will make a pull request addressing this issue.

seratch added a commit to seratch/hubot-slack that referenced this issue May 14, 2020
@seratch seratch closed this as completed May 18, 2020
seratch added a commit that referenced this issue May 18, 2020
Fix #593 New option to ignore events by other workspace users in shared channels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant