Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add salesforce record id type #390

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

WilliamBergamin
Copy link
Contributor

@WilliamBergamin WilliamBergamin commented Dec 9, 2024

Summary

This PR aims to add a new hidden type slack#/types/salesforce_record_id

This type behaves as a string, similar to other id types like user_is, canvas_id etc ...

Special notes

This aims to unblock slackapi/deno-slack-hub#66

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've ran deno task test after making the changes.

@WilliamBergamin WilliamBergamin added feature request New feature or request semver:minor requires a minor version number bump labels Dec 9, 2024
@WilliamBergamin WilliamBergamin self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (a30b23b) to head (de4b93a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          67       67           
  Lines        2742     2743    +1     
  Branches      148      148           
=======================================
+ Hits         2702     2703    +1     
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergamin WilliamBergamin marked this pull request as ready for review December 9, 2024 21:38
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner December 9, 2024 21:38
Comment on lines +100 to +102
: Param["type"] extends
| typeof SlackSchemaTypes.rich_text
| typeof SlackSchemaTypes.expanded_rich_text ? UnknownRuntimeType
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is just a NIT to clean up the logic and follow similar patterns

@WilliamBergamin WilliamBergamin merged commit ca8fc2c into main Dec 10, 2024
12 checks passed
@WilliamBergamin WilliamBergamin deleted the add-new-record-type branch December 10, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request semver:minor requires a minor version number bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants