feat: Add new type list_id, builtins for Add/Remove Reactions and many List-related functions
#361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions, too. also updates instructions for how to generate built-in function definitions using updated `functions.list` API endpoint
WilliamBergamin
approved these changes
Sep 6, 2024
WilliamBergamin
requested changes
Sep 6, 2024
added 2 commits
September 6, 2024 15:03
… finds an unfamiliar parameter type. Update generated list functions with new list_id type.
filmaj
changed the title
list_id, builtins for Add/Remove Reactions and many List-related functions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=========================================
+ Coverage 0 98.66% +98.66%
=========================================
Files 0 73 +73
Lines 0 2997 +2997
Branches 0 147 +147
=========================================
+ Hits 0 2957 +2957
- Misses 0 40 +40 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
approved these changes
Sep 6, 2024
| @@ -21,3 +21,5 @@ echo "Formatting Slack function files..." | |||
| deno fmt --quiet ../*.ts | |||
| echo "Linting Slack function files..." | |||
| deno lint --quiet ../*.ts | |||
| echo "Type-checking Slack function files..." | |||
| deno check --quiet ../*.ts | |||
There was a problem hiding this comment.
Good catch 💯 I thought this was already in there
| @@ -73,8 +73,14 @@ const propertyToTypeScript = ( | |||
| property: FunctionProperty, | |||
| ): string => { | |||
| const typescript = []; | |||
| const sdkType = schemaTypeMap[property.type]; | |||
There was a problem hiding this comment.
Nice improvement 💯 makes the code clearer also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions.listAPI endpoint