New team_id type, updates to built-ins, updated builtin function generation script instructions
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 6, 2024 13:25
- updated some property titles - create-channel built in now accepts an optional team id (fixes #267) - added new Add Bookmark builtin - openform now accepts an on_submit_function_config input
added 2 commits
June 6, 2024 16:40
…in generatio nscript readme.
…, remove deprecated deno.jsonc properties.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 98.37% 98.43% +0.05%
==========================================
Files 64 65 +1
Lines 2463 2677 +214
Branches 147 147
==========================================
+ Hits 2423 2635 +212
- Misses 40 42 +2 ☔ View full report in Codecov by Sentry. |
added 2 commits
June 7, 2024 12:36
…ial list of pre-approved hidden params we publicize anyways to account for exposing it previously
filmaj
commented
Jun 7, 2024
| "singleQuote": false, | ||
| "useTabs": false | ||
| } | ||
| "include": [ |
There was a problem hiding this comment.
Flattening out deno.jsonc to remove deprecation warnings from deno output
filmaj
commented
Jun 7, 2024
| @@ -0,0 +1,50 @@ | |||
| /** This file was autogenerated. Follow the steps in src/schema/slack/functions/_scripts/README.md to rebuild **/ | |||
There was a problem hiding this comment.
New built-in that's been public for a little bit.
filmaj
commented
Jun 7, 2024
| @@ -9,6 +9,11 @@ export default DefineFunction({ | |||
| title: "Create a channel", | |||
| input_parameters: { | |||
| properties: { | |||
| team_id: { | |||
There was a problem hiding this comment.
This is the new property that fixes #267
filmaj
commented
Jun 7, 2024
| @@ -1,17 +1,18 @@ | |||
| const SlackPrimitiveTypes = { | |||
| user_id: "slack#/types/user_id", | |||
| blocks: "slack#/types/blocks", | |||
There was a problem hiding this comment.
Just alphabetizing these
filmaj
commented
Jun 7, 2024
| message_ts: "slack#/types/message_ts", | ||
| oauth2: "slack#/types/credential/oauth2", | ||
| rich_text: "slack#/types/rich_text", | ||
| team_id: "slack#/types/team_id", |
There was a problem hiding this comment.
New type here; I am about to test this manually in an app to make sure it works.
WilliamBergamin
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
team_idtypeteam_idparameter to Create Channel and Create Usergroup builtins (relates to but does not resolve it [BUG] Unable to passteam_idto built-in Slack functionSchema.slack.functions.CreateChannel#267)functions.listAPI will be in flux as it is under active development. As such, the generation instructions have changed to use a different set of APIs as a replacement. The new way is a bit more involved manual process, but it is not so bad (7 API calls using the API Tester instead of 1).is_hiddenparameter. This means we have released hidden parameters in this SDK 😬 to maintain backwards compatibility, handling of hidden parameters is now a manual process. The generation script will warn if it encounters a hidden parameter. Instructions are updated to have the maintainer carefully review the generated code with respect to hidden parameters. Existing hidden parameters will be kept, but any future hidden parameters should be removed.How To Deal With Hidden Parameters
We could instead improve the generation script to manually hard-code the list of built-in functions that have had hidden parameters previously exposed, and ignore those / proceed with generation code for them (to maintain backwards compatibility). Any other hidden parameters except the ones already exposed will be skipped for code generation. Thoughts @WilliamBergamin ?