Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Share Canvas in thread to the deno sdk #311

Merged
merged 3 commits into from
May 3, 2024
Merged

Conversation

rafaelamsili
Copy link
Contributor

@rafaelamsili rafaelamsili commented May 2, 2024

Summary

This PR add the new released Share Canvas in thread to the deno sdk and update labels for the owner in copy canvas, create canvas and create channel canvas

Field Type Description Required
canvas_id slack#/types/canvas_id The id of the canvas that will be shared true
message_context slack#/types/message_context The reference to the root message that the canvas will be shared as a reply true
access_level string The access level that the canvas will be shared. It can be view or edit true
message slack#/types/rich_text Optional rich text message that will be send when sharing the canvas false
reply_broadcast boolean If selected will also broadcast the message to the channel false - defaults to false

Testing

Create an app using the functions and see that it perform the actions

Requirements

  • Canvas need to be enabled in the org
  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've ran deno task test after making the changes.

@rafaelamsili rafaelamsili requested a review from a team as a code owner May 2, 2024 14:31
@@ -22,7 +22,7 @@ export default DefineFunction({
},
owner_id: {
type: SlackTypes.user_id,
description: "Canvas owner id",
description: "Person",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label changed in the built in

@filmaj
Copy link
Contributor

filmaj commented May 3, 2024

@rafaelamsili did you run the generation script for this (it seems to me like no)? Because the mod.ts is missing the import of the new function, so there's no way for a developer to actually use this as-is.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one thing we're missing is importing the new function in this file and exposing it as part of the export: https://github.com/slackapi/deno-slack-sdk/blob/main/src/schema/slack/functions/mod.ts

@rafaelamsili rafaelamsili requested a review from filmaj May 3, 2024 17:30
@filmaj filmaj merged commit c6b5344 into main May 3, 2024
9 checks passed
@filmaj filmaj deleted the rafi_share_thread branch May 3, 2024 17:31
@rafaelamsili
Copy link
Contributor Author

@rafaelamsili did you run the generation script for this (it seems to me like no)? Because the mod.ts is missing the import of the new function, so there's no way for a developer to actually use this as-is.

Good catch 🦅 👁️ about the mod change. I ran the generation script but there was a lot of noise from other functions so I just committed those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants