-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Share Canvas in thread to the deno sdk #311
Conversation
@@ -22,7 +22,7 @@ export default DefineFunction({ | |||
}, | |||
owner_id: { | |||
type: SlackTypes.user_id, | |||
description: "Canvas owner id", | |||
description: "Person", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label changed in the built in
@rafaelamsili did you run the generation script for this (it seems to me like no)? Because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one thing we're missing is importing the new function in this file and exposing it as part of the export: https://github.com/slackapi/deno-slack-sdk/blob/main/src/schema/slack/functions/mod.ts
Good catch 🦅 👁️ about the mod change. I ran the generation script but there was a lot of noise from other functions so I just committed those changes. |
Summary
This PR add the new released Share Canvas in thread to the deno sdk and update labels for the owner in copy canvas, create canvas and create channel canvas
view
oredit
false
Testing
Create an app using the functions and see that it perform the actions
Requirements
deno task test
after making the changes.