Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #480 #479 Adds updating views on submission for Japanese docs #494

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

wongjas
Copy link
Member

@wongjas wongjas commented Oct 13, 2021

Fixes #480. Adds the fixes in #479 (Updating views on view_submission) for the Japanese docs.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@wongjas wongjas requested a review from seratch October 13, 2021 04:44
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #494 (49ced4a) into main (16ea0bd) will not change coverage.
The diff coverage is n/a.

❗ Current head 49ced4a differs from pull request most recent head 74b0a9f. Consider uploading reports for the commit 74b0a9f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files         167      167           
  Lines        5533     5533           
=======================================
  Hits         5059     5059           
  Misses        474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ea0bd...74b0a9f. Read the comment docs.

@wongjas wongjas marked this pull request as ready for review October 13, 2021 05:06
@seratch seratch added the docs Improvements or additions to documentation label Oct 13, 2021
@seratch seratch added this to the 1.9.3 milestone Oct 13, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you check my comments?


##### モーダル送信でのビューの更新

`view_submission` リクエストに対してモーダルを更新するには、`update` 型の `response_action` と新しく作成した `view` を指定すると確認を示します。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`view_submission` リクエストに対してモーダルを更新するには、`update` 型の `response_action` と新しく作成した `view` を指定すると確認を示します
`view_submission` リクエストに対してモーダルを更新するには、リクエストの確認の中で `update` を指定した `response_action` と新しく作成した `view` を指定します

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wongjas Sorry, my suggestion repeats 指定する in a sentence 🤦

How about this one?

`view_submission` リクエストに対してモーダルを更新するには、リクエストの確認の中で `update` という `response_action` と新しく作成した `view` を指定します。

Instead of update という, update というタイプの also works! In my opinion, we still should avoid having "型" here to avoid confusion.

def handle_submission(ack, body):
ack(response_action="update", view=build_new_view(body))
```
この例と同様に、モーダルでの送信イベントに対して、<a href="https://api.slack.com/surfaces/modals/using#displaying_errors">エラーを表示する</a>プションもあります。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
この例と同様に、モーダルでの送信イベントに対して、<a href="https://api.slack.com/surfaces/modals/using#displaying_errors">エラーを表示する</a>プションもあります
この例と同様に、モーダルでの送信リクエストに対して、<a href="https://api.slack.com/surfaces/modals/using#displaying_errors">エラーを表示する</a>ためのオプションもあります

@seratch
Copy link
Member

seratch commented Oct 13, 2021

The CI build failures are due to new detection by the latest pytype. I will check it out later.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the suggestion to apply the change in my last comment

docs/_basic/ja_listening_modals.md Outdated Show resolved Hide resolved
@seratch seratch merged commit 01ec9b6 into slackapi:main Oct 13, 2021
@seratch seratch changed the title Fix #479 Adds updating views on submission for Japanese docs Fix #480 #479 Adds updating views on submission for Japanese docs Oct 13, 2021
@wongjas wongjas deleted the jwong_fix_479 branch October 13, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Japanese: Apply #479 changes to the documents
2 participants