-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #480 #479 Adds updating views on submission for Japanese docs #494
Conversation
Codecov Report
@@ Coverage Diff @@
## main #494 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 167 167
Lines 5533 5533
=======================================
Hits 5059 5059
Misses 474 474 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you check my comments?
docs/_basic/ja_listening_modals.md
Outdated
|
||
##### モーダル送信でのビューの更新 | ||
|
||
`view_submission` リクエストに対してモーダルを更新するには、`update` 型の `response_action` と新しく作成した `view` を指定すると確認を示します。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`view_submission` リクエストに対してモーダルを更新するには、`update` 型の `response_action` と新しく作成した `view` を指定すると確認を示します。 | |
`view_submission` リクエストに対してモーダルを更新するには、リクエストの確認の中で `update` を指定した `response_action` と新しく作成した `view` を指定します。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wongjas Sorry, my suggestion repeats 指定する in a sentence 🤦
How about this one?
`view_submission` リクエストに対してモーダルを更新するには、リクエストの確認の中で `update` という `response_action` と新しく作成した `view` を指定します。
Instead of update
という, update
というタイプの also works! In my opinion, we still should avoid having "型" here to avoid confusion.
docs/_basic/ja_listening_modals.md
Outdated
def handle_submission(ack, body): | ||
ack(response_action="update", view=build_new_view(body)) | ||
``` | ||
この例と同様に、モーダルでの送信イベントに対して、<a href="https://api.slack.com/surfaces/modals/using#displaying_errors">エラーを表示する</a>プションもあります。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この例と同様に、モーダルでの送信イベントに対して、<a href="https://api.slack.com/surfaces/modals/using#displaying_errors">エラーを表示する</a>プションもあります。 | |
この例と同様に、モーダルでの送信リクエストに対して、<a href="https://api.slack.com/surfaces/modals/using#displaying_errors">エラーを表示する</a>ためのオプションもあります。 |
The CI build failures are due to new detection by the latest pytype. I will check it out later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the suggestion to apply the change in my last comment
Fixes #480. Adds the fixes in #479 (Updating views on
view_submission
) for the Japanese docs.Category (place an
x
in each of the[ ]
)slack_bolt.App
and/or its core componentsslack_bolt.async_app.AsyncApp
and/or its core componentsslack_bolt.adapter
/docs
Requirements (place an
x
in each[ ]
)Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.sh
after making the changes.