Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agents & Assistants document page #1175

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Oct 4, 2024

This pull request adds new document pages for Agents & Assistants feature. See also: #1162

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added the docs Improvements or additions to documentation label Oct 4, 2024
@seratch seratch added this to the 1.21.0 milestone Oct 4, 2024
@seratch seratch requested a review from misscoded October 4, 2024 02:11
@seratch seratch self-assigned this Oct 4, 2024
@seratch seratch marked this pull request as ready for review October 4, 2024 02:12
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (56d5ca3) to head (83cd685).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1175   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         195      195           
  Lines        6631     6631           
=======================================
  Hits         6102     6102           
  Misses        529      529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few minor suggestions but not blockers.

docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
Copy link
Contributor

@misscoded misscoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some language-specific feedback, but nothing that would block it being published. Feel free to incorporate at your discretion.

docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
docs/content/basic/assistant.md Outdated Show resolved Hide resolved
Co-authored-by: Alissa Renz <[email protected]>
Co-authored-by: Fil Maj <[email protected]>
@seratch
Copy link
Member Author

seratch commented Oct 16, 2024

Thank you so much for the reviews! All the points are now reflected. I will merge this PR once the new version including the feature addition is released.

@seratch seratch enabled auto-merge (squash) October 17, 2024 02:30
@seratch seratch disabled auto-merge October 17, 2024 02:30
@seratch seratch merged commit 3c993d5 into slackapi:main Oct 17, 2024
14 checks passed
@seratch seratch deleted the assistant-docs branch October 17, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants