Update opening-modals.md (removed extra s) #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All I did was remove an 's' after the "Modals link that seems like it isn't supposed to be there.
|
Thanks for the contribution! Before we can merge this, we need @Rat-Fiend to sign the Salesforce Inc. Contributor License Agreement. |
|
Love a spelling tweak - @Rat-Fiend mind signing the CLA? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 195 195
Lines 6631 6631
=======================================
Hits 6102 6102
Misses 529 529 ☔ View full report in Codecov by Sentry. |
|
Signed it. Thanks for the quick response.
…On Mon, Sep 16, 2024, 3:08 PM Sarah Jiang ***@***.***> wrote:
Love a spelling tweak - @Rat-Fiend <https://github.com/Rat-Fiend> mind
signing the CLA?
—
Reply to this email directly, view it on GitHub
<#1161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6O7OZ4XOVOJWQ4JQG7YSN3ZW5JHPAVCNFSM6AAAAABOKE2KJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJUGEYTIMZXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
WilliamBergamin
approved these changes
Sep 16, 2024
seratch
pushed a commit
to seratch/bolt-python
that referenced
this pull request
Sep 18, 2024
All I did was remove an 's' after the "Modals link that seems like it isn't supposed to be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All I did was remove an 's' after the "Modals" link that seems like it isn't supposed to be there.
The goal is to fix a grammar issue. No issue numbers referenced.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.