Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #947 Enable to use app.client with passed token for single workspace apps #948

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented May 31, 2021

Summary

Refer to #947 for details. If we need to have some discussion about this, let's use the issue, not this PR.

For the comments about the changes in this PR, please feel free to join as a reviewer!

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality semver:minor labels May 31, 2021
@seratch seratch added this to the 3.4.0 milestone May 31, 2021
@seratch seratch self-assigned this May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #948 (03bbe21) into main (6007b1b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #948   +/-   ##
=======================================
  Coverage   66.19%   66.19%           
=======================================
  Files          13       13           
  Lines        1207     1207           
  Branches      356      356           
=======================================
  Hits          799      799           
  Misses        338      338           
  Partials       70       70           
Impacted Files Coverage Δ
src/App.ts 82.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6007b1b...03bbe21. Read the comment docs.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants