Fix #497 Add types of state.values on modal submission #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
seratch
commented
Apr 14, 2021
| export interface ViewOutput { | ||
| id: string; | ||
| callback_id: string; | ||
| team_id: string; | ||
| app_installed_team_id?: string; |
There was a problem hiding this comment.
While doing the tests for this pull request changes, I found this field is missing.
| selected_channel?: string | null; | ||
| selected_user?: string | null; | ||
| selected_option?: ViewStateSelectedOption | null; | ||
| selected_conversations?: string[]; |
There was a problem hiding this comment.
As far as I know, there is no pattern to have null for the array ones.
Codecov Report
@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage 66.08% 66.08%
=======================================
Files 13 13
Lines 1200 1200
Branches 353 353
=======================================
Hits 793 793
Misses 338 338
Partials 69 69 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #497 by adding complete types for the elements in
view.state.valuesinview_submissionpayloadsRequirements (place an
xin each[ ])