Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few array field definition errors in TypeScript #873

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 9, 2021

Summary

This pull request resolves a few type errors in block_actions & interactive_message payloads. As these are obvious bugs, we should not keep the backward compatibility with the types.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific labels Apr 9, 2021
@seratch seratch added this to the 3.4.0 milestone Apr 9, 2021
@seratch seratch self-assigned this Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #873 (69534b6) into main (4365f45) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   66.08%   66.08%           
=======================================
  Files          13       13           
  Lines        1200     1200           
  Branches      353      353           
=======================================
  Hits          793      793           
  Misses        338      338           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4365f45...69534b6. Read the comment docs.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely agree @seratch. Thanks for the fix!

@seratch
Copy link
Member Author

seratch commented Apr 9, 2021

Thanks for quick check 👍

@seratch seratch merged commit 23b4f80 into slackapi:main Apr 9, 2021
@seratch seratch deleted the array-field-bugs-in-ts branch April 9, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants