Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #718 add tokenVerificationEnabled flag to App constructor #863

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Fix #718 add tokenVerificationEnabled flag to App constructor #863

merged 1 commit into from
Apr 7, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 30, 2021

Summary

This pull request resolves #718 by introducing a new flag in the App constructor. See the issue for details.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality semver:minor labels Mar 30, 2021
@seratch seratch added this to the 3.4.0 milestone Mar 30, 2021
@seratch seratch requested review from mwbrooks and stevengill March 30, 2021 14:54
@seratch seratch self-assigned this Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited
Loading

Codecov Report

Merging #863 (4f99439) into main (78e605b) will increase coverage by 0.03%.
The diff coverage is 76.47%.

❗ Current head 4f99439 differs from pull request most recent head 8804d66. Consider uploading reports for the commit 8804d66 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
+ Coverage   66.05%   66.08%   +0.03%     
==========================================
  Files          13       13              
  Lines        1193     1200       +7     
  Branches      351      353       +2     
==========================================
+ Hits          788      793       +5     
- Misses        336      338       +2     
  Partials       69       69
Impacted Files Coverage Δ
src/App.ts 82.76% <76.47%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e605b...8804d66. Read the comment docs.

seratch
seratch commented Mar 30, 2021
View reviewed changes
src/App.ts
@@ -80,6 +80,7 @@ export interface AppOptions {
clientOptions?: Pick<WebClientOptions, 'slackApiUrl'>;
socketMode?: boolean;
developerMode?: boolean;
tokenVerificationEnabled?: boolean;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the essential changes for #718, I organized the internals of App a bit and added more comments. If other maintainers prefer having these changes in a different pull request, I will move these changes to another pull request.

stevengill
stevengill approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @seratch

@seratch seratch mentioned this pull request Apr 2, 2021
Closed
2 tasks
@seratch seratch merged commit f1e9fff into slackapi:main Apr 7, 2021
@seratch seratch deleted the issue-718-tokenVerificationEnabledFlag branch April 7, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengill stevengill stevengill approved these changes

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality semver:minor
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Add token_verification_enabled option to App
2 participants
@seratch @stevengill