Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small clarification constraint reference #844

Merged

Conversation

shaydewael
Copy link
Contributor

Summary

Tiny clarification around constraint objects

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #844 (1bae60c) into main (ebc90bf) will not change coverage.
The diff coverage is n/a.

❗ Current head 1bae60c differs from pull request most recent head 196380d. Consider uploading reports for the commit 196380d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   65.89%   65.89%           
=======================================
  Files          13       13           
  Lines        1173     1173           
  Branches      343      343           
=======================================
  Hits          773      773           
  Misses        334      334           
  Partials       66       66           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc90bf...196380d. Read the comment docs.

@seratch seratch added docs M-T: Documentation work only and removed untriaged labels Mar 22, 2021
@seratch seratch merged commit 0e469c9 into slackapi:main Mar 22, 2021
@seratch
Copy link
Member

seratch commented Mar 22, 2021

oh no - merging this PR included four commits 🤔 - I will resolve some issues in the other commits later.

@seratch seratch added this to the 3.4.0 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants