Fix #342 TypeScript: multi-select/radio button block elements are still unsupported #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are still unsupported
seratch
commented
Dec 16, 2019
| | OverflowAction | ||
| | DatepickerAction; | ||
| | DatepickerAction | ||
| | RadioButtonsAction; |
There was a problem hiding this comment.
radio_buttons were not added when it was added.
| /** | ||
| * An action from a select menu with external data source | ||
| */ | ||
| export interface ExternalSelectAction extends BasicElementAction<'external_select'> { | ||
| selected_option?: Option; |
There was a problem hiding this comment.
I'm afraid that this field has been missing since this interface was added.
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 73.35% 73.35%
=======================================
Files 7 7
Lines 503 503
Branches 146 146
=======================================
Hits 369 369
Misses 102 102
Partials 32 32Continue to review full report at Codecov.
|
seratch
added
bug
stevengill
approved these changes
Dec 16, 2019
aoberoi
approved these changes
Dec 16, 2019
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #342 by adding the following types of
block_actionsin TypeScript.(To be clear, JavaScript users don't need to wait for this fix to use newly added block elements)
Requirements (place an
xin each[ ])