Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames japanese doc files #273

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Renames japanese doc files #273

merged 1 commit into from
Oct 3, 2019

Conversation

ikenami
Copy link
Contributor

@ikenami ikenami commented Oct 3, 2019

Summary

Renames doc files that started with "jp_" to "ja_" in order to match the other existing japanese doc files.

Requirements (place an x in each [ ])

Renames from "jp_" to "ja_" in order to match the other japanese doc files.
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   59.95%   59.95%           
=======================================
  Files           7        7           
  Lines         492      492           
  Branches      136      136           
=======================================
  Hits          295      295           
  Misses        169      169           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe866d...1e46b6a. Read the comment docs.

@ikenami ikenami changed the title Renames japanece doc files Renames japanese doc files Oct 3, 2019
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM 👍 (just in case, I've verified if the changes work)

@seratch seratch added the docs M-T: Documentation work only label Oct 3, 2019
@shaydewael shaydewael merged commit ff81e06 into slackapi:master Oct 3, 2019
@ikenami ikenami deleted the doc-update branch October 3, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants