Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: install @types/express@^v5 as a dev dependency for express@^5 #2355

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Dec 4, 2024

Summary

This PR bumps @types/express to v5 to match the included express v5 package. These typings are also moved into the devDependencies since these are required for just the build step AFAIK! Fixes #2354.

Requirements

@zimeg zimeg added semver:patch dependencies Pull requests that update a dependency file labels Dec 4, 2024
@zimeg zimeg added this to the 4.1.2 milestone Dec 4, 2024
@zimeg zimeg requested review from seratch and a team December 4, 2024 20:23
@zimeg zimeg self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (606b243) to head (b8d66fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2355   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg
Copy link
Member Author

zimeg commented Dec 4, 2024

It's curious that @dependabot didn't catch this in the last round of updates... We seem to include just a handful of dependencies in this list, but I'm wondering if we want to revisit this?

https://github.com/slackapi/bolt-js/blob/main/.github/dependabot.yml

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; LGTM

@seratch
Copy link
Member

seratch commented Dec 5, 2024

@zimeg Yeah, we can add more dependencies to the list. At least, having @types/* should be fine

@zimeg
Copy link
Member Author

zimeg commented Dec 5, 2024

@seratch Thanks! And adding some dependencies sounds good. 🚀

It makes sense that express is kept at a minimum 5.0.0 IMO to avoid requiring updates across all dependencies of an app, but that might be interesting to revisit for keeping up with bug fixes and added features of bolt dependencies.

A combination of options for allow in this file seem promising for updating a select few more dependencies also: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#allow

Hoping to explore this more after thinking about versions a bit, but I'd love to know if you have immediate thoughts on these numbers 🙏

@zimeg zimeg merged commit fa14b38 into main Dec 5, 2024
18 checks passed
@zimeg zimeg deleted the zimeg-build-express-types-v5 branch December 5, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file semver:patch TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.1.1 has inconsistent types with express v5
2 participants