Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: general page cleanup #2310

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

lukegalbraithrussell
Copy link
Contributor

Summary

This is quick run through of the site and cleans up stuf. Highlights:

  • Steps from apps now has a very clear URL/name to prevent confusion (now is legacy/steps-from-apps). Redirect added
  • Most of the <details> are removed as they're unnecessary with shorter pages
  • standardized headings

Requirements (place an x in each [ ])

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (4b6b25f) to head (431210d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2310   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      651      651           
=======================================
  Hits         6911     6911           
  Misses        553      553           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +105 to +114
{
type: "context",
elements: [
{
type: "mrkdwn",
text: "About the simplest modal you could conceive of :smile:\n\nMaybe <https://api.slack.com/reference/block-kit/interactive-components|*make the modal interactive*> or <https://api.slack.com/surfaces/modals/using#modifying|*learn more advanced modal use cases*>."
text: "Psssst this modal was designed using <https://api.slack.com/tools/block-kit-builder|*Block Kit Builder*>"
}
},
{
type: "context",
elements: [
{
type: "mrkdwn",
text: "Psssst this modal was designed using <https://api.slack.com/tools/block-kit-builder|*Block Kit Builder*>"
}
]
}
]
}
});

logger.info(result);
}
catch (error) {
logger.error(error);
}
});
```
]
}
]
Copy link
Contributor Author

@lukegalbraithrussell lukegalbraithrussell Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a code snippet pulled from a <details> element no code was actually changed promise

@lukegalbraithrussell lukegalbraithrussell requested a review from a team October 29, 2024 19:33
@lukegalbraithrussell lukegalbraithrussell added the docs M-T: Documentation work only label Oct 29, 2024
@lukegalbraithrussell lukegalbraithrussell marked this pull request as ready for review October 29, 2024 19:33
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge and nice work on the clean ups! ✨ 🧹 💨

✅ Throwing an approval on it with a few minor suggestions, but you may want someone else from the @slackapi/developer-education team to also take a look.


Now you can test your Slack app by inviting your app to a channel then saying “hello” (lower-case). Just like in the [Getting Started guide](/getting-started, your app should respond back:
Now you can test your Slack app by inviting your app to a channel then saying “hello” (lower-case). Just like in the [Getting Started guide](/getting-started), your app should respond back:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof, good catch!

docs/content/migration/migration-v4.md Outdated Show resolved Hide resolved
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for making the changes to JP version too!

@@ -1,20 +1,17 @@
---
title: Heroku Platform
title: Deploying to Heroku
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lukegalbraithrussell lukegalbraithrussell merged commit 78e0628 into main Oct 30, 2024
20 checks passed
@lukegalbraithrussell lukegalbraithrussell deleted the docs-luke-oct-29-cleanup branch October 30, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants