fix: do not log ack timeout error if aws receiver has no registered handlers #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen using the `AwsLambdaReceiver`, do not log out an error related to `ack` timeout. fixes #2284. - also, expose `unhandledRequestTimeoutMillis` receiver option on `AwsLambdaReceiver`, just like `HTTPReceiver` has (to ease testing of timeouts, mainly) - expose a `logger` getter on `AwsLambdaReceiver` (to ease testing, mainly)
filmaj
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bolt-four #2285 +/- ##
=============================================
- Coverage 90.79% 90.72% -0.08%
=============================================
Files 20 20
Lines 5576 5586 +10
Branches 602 600 -2
=============================================
+ Hits 5063 5068 +5
- Misses 505 510 +5
Partials 8 8 ☔ View full report in Codecov by Sentry. |
srajiang
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2284.
unhandledRequestTimeoutMillisreceiver option onAwsLambdaReceiver, just likeHTTPReceiverhas (to ease testing of timeouts, mainly)loggergetter onAwsLambdaReceiver(to ease testing, mainly)