Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document custom step usage #2198
docs: document custom step usage #2198
Changes from 1 commit
a050256
188813c
f31d8df
3faab87
b46f470
1b79873
630f188
caec4b1
247b4c7
11a42c0
e933eda
87730ef
bea900d
b10bbb0
e3ac1eb
717028f
f15413a
60261d0
23ef516
3aa9f34
5132ad4
7f14da1
90ce812
0451502
0110bf2
960d18e
d73f717
5fa091a
70240f9
56ab543
44da1d1
b353056
34fefa2
6779dbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the
ack
here since this isn't provided for function executionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep it in the docs, there are a number of issues opened related to calling ack before executing custom logic
Keeping this in hopes that it will help developers avoid a bug 🙏
We can remove it in a follow up PR as well 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the
function_executed
events are actually different from other events and can't useack
at all!Within JavaScript code this is
undefined
within the listener so this call will error 😬 It's not so clear from this picture but the hover hint is hinting at this in a TypeScript project:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested tweak to the introduction here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good 🙇 provides more information without duplicating documentation from api.slack.com
I had to adapt this slightly to because open modal views are not yet supported, but hopefully soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need help with the translation 🙏